Handle comments before rule colons - #786
Merged
Merged
Conversation
ydah
force-pushed
the
fix/rule-lhs-comment-lookahead
branch
from
April 28, 2026 08:12
98f82d8 to
fa4f478
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a lexer edge case where a rule name followed by a block comment before
:is tokenized incorrectly.Previously, the lexer only looked through whitespace when deciding whether an identifier should be emitted as
IDENT_COLON. As a result,inputs like the following were parsed incorrectly:
stmt /* some block comment */ :This caused rule headers to be tokenized as IDENTIFIER instead of IDENT_COLON, which then led to parse errors on grammars.